---

yaml
---
r: 113840
b: refs/heads/master
c: 69025c9
h: refs/heads/master
v: v3

[refs]

@@ -1,2 +1,2 @@
 ---
-refs/heads/master: 06fcadbf8b63e395d3ae8421a8c3cb2dfd0bc56b
+refs/heads/master: 69025c934b21a9ce49a76dfef59f1ebdfbe96c78

trunk/drivers/media/video/zr364xx.c

@@ -641,35 +641,31 @@ static int zr364xx_open(struct inode *inode, struct file *file)
 
 	DBG("zr364xx_open");
 
+	mutex_lock(&cam->lock);
+
 	cam->skip = 2;
 
-	lock_kernel();
 	err = video_exclusive_open(inode, file);
-	if (err < 0) {
-		unlock_kernel();
-		return err;
-	}
+	if (err < 0)
+		goto out;
 
 	if (!cam->framebuf) {
 		cam->framebuf = vmalloc_32(MAX_FRAME_SIZE * FRAMES);
 		if (!cam->framebuf) {
 			info("vmalloc_32 failed!");
-			unlock_kernel();
-			return -ENOMEM;
+			err = -ENOMEM;
+			goto out;
 		}
 	}
 
-	mutex_lock(&cam->lock);
 	for (i = 0; init[cam->method][i].size != -1; i++) {
 		err =
 		    send_control_msg(udev, 1, init[cam->method][i].value,
 				     0, init[cam->method][i].bytes,
 				     init[cam->method][i].size);
 		if (err < 0) {
 			info("error during open sequence: %d", i);
-			mutex_unlock(&cam->lock);
-			unlock_kernel();
-			return err;
+			goto out;
 		}
 	}
 
@@ -679,10 +675,11 @@ static int zr364xx_open(struct inode *inode, struct file *file)
 	 * like Ekiga does during its startup, can crash the webcam
 	 */
 	mdelay(100);
+	err = 0;
 
+out:
 	mutex_unlock(&cam->lock);
-	unlock_kernel();
-	return 0;
+	return err;
 }