Skip to content

Commit

Permalink
[SCSI] isci: fix event-get pointer increment
Browse files Browse the repository at this point in the history
Hardware only increments the put pointer on event types >= 4.  Do not
increment the get pointer for event type 3.

Reported-by: Kapil Karkra <kapil.karkra@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
  • Loading branch information
Dan Williams authored and James Bottomley committed Aug 24, 2011
1 parent 9b4be52 commit 77cd72a
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions drivers/scsi/isci/host.c
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,9 @@ static void sci_controller_process_completions(struct isci_host *ihost)
break;

case SCU_COMPLETION_TYPE_EVENT:
sci_controller_event_completion(ihost, ent);
break;

case SCU_COMPLETION_TYPE_NOTIFY: {
event_cycle ^= ((event_get+1) & SCU_MAX_EVENTS) <<
(SMU_COMPLETION_QUEUE_GET_EVENT_CYCLE_BIT_SHIFT - SCU_MAX_EVENTS_SHIFT);
Expand Down

0 comments on commit 77cd72a

Please sign in to comment.