Skip to content

Commit

Permalink
BKL: Remove BKL from afs
Browse files Browse the repository at this point in the history
The BKL is only used in put_super and fill_super, which are both protected
by the superblocks s_umount rw_semaphore. Therefore it is safe to remove
the BKL entirely.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: linux-afs@lists.infradead.org
Cc: David Howells <dhowells@redhat.com>
  • Loading branch information
Arnd Bergmann committed Oct 4, 2010
1 parent cdbd2b0 commit 77f2fe0
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions fs/afs/super.c
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
#include <linux/mount.h>
#include <linux/init.h>
#include <linux/slab.h>
#include <linux/smp_lock.h>
#include <linux/fs.h>
#include <linux/pagemap.h>
#include <linux/parser.h>
Expand Down Expand Up @@ -302,15 +301,12 @@ static int afs_fill_super(struct super_block *sb, void *data)
struct inode *inode = NULL;
int ret;

lock_kernel();

_enter("");

/* allocate a superblock info record */
as = kzalloc(sizeof(struct afs_super_info), GFP_KERNEL);
if (!as) {
_leave(" = -ENOMEM");
unlock_kernel();
return -ENOMEM;
}

Expand Down Expand Up @@ -344,7 +340,6 @@ static int afs_fill_super(struct super_block *sb, void *data)
sb->s_root = root;

_leave(" = 0");
unlock_kernel();
return 0;

error_inode:
Expand All @@ -358,7 +353,6 @@ static int afs_fill_super(struct super_block *sb, void *data)
sb->s_fs_info = NULL;

_leave(" = %d", ret);
unlock_kernel();
return ret;
}

Expand Down Expand Up @@ -458,12 +452,8 @@ static void afs_put_super(struct super_block *sb)

_enter("");

lock_kernel();

afs_put_volume(as->volume);

unlock_kernel();

_leave("");
}

Expand Down

0 comments on commit 77f2fe0

Please sign in to comment.