Skip to content

Commit

Permalink
perf symbols: Introduce dso__build_id_equal
Browse files Browse the repository at this point in the history
Will be used in more places.

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frédéric Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
LKML-Reference: <1258757489-5978-3-git-send-email-acme@infradead.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Arnaldo Carvalho de Melo authored and Ingo Molnar committed Nov 21, 2009
1 parent fd7a346 commit 78075ca
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions tools/perf/util/symbol.c
Original file line number Diff line number Diff line change
Expand Up @@ -884,6 +884,11 @@ static int dso__load_sym(struct dso *self, struct map *map, const char *name,
return err;
}

static bool dso__build_id_equal(const struct dso *self, u8 *build_id)
{
return memcmp(self->build_id, build_id, sizeof(self->build_id)) == 0;
}

bool dsos__read_build_ids(void)
{
bool have_build_id = false;
Expand Down Expand Up @@ -1099,8 +1104,7 @@ int dso__load(struct dso *self, struct map *map, symbol_filter_t filter)
sizeof(build_id)) < 0)
goto more;
compare_build_id:
if (memcmp(build_id, self->build_id,
sizeof(self->build_id)) != 0)
if (!dso__build_id_equal(self, build_id))
goto more;
}

Expand Down

0 comments on commit 78075ca

Please sign in to comment.