Skip to content

Commit

Permalink
ide-pmac: remove control register messing from pmac_ide_dma_check()
Browse files Browse the repository at this point in the history
pmac_ide_do_setfeature() contains matching nIEN setting/clearing so this
Device Control register messing in pmac_ide_dma_check() is totally unnecessary.

Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
  • Loading branch information
Bartlomiej Zolnierkiewicz committed Oct 13, 2007
1 parent 90f72ec commit 7810394
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/ide/ppc/pmac.c
Original file line number Diff line number Diff line change
Expand Up @@ -1784,7 +1784,7 @@ pmac_ide_dma_check(ide_drive_t *drive)
drive->using_dma = pmac_ide_udma_enable(drive, mode);
else if (mode >= XFER_MW_DMA_0)
drive->using_dma = pmac_ide_mdma_enable(drive, mode);
hwif->OUTB(0, IDE_CONTROL_REG);

/* Apply settings to controller */
pmac_ide_do_update_timings(drive);
}
Expand Down

0 comments on commit 7810394

Please sign in to comment.