Skip to content

Commit

Permalink
drm: fix leak of cliprects in drm_rmdraw()
Browse files Browse the repository at this point in the history
Signed-off-by: Zhenyu Wang <zhenyu.z.wang@intel.com>
Signed-off-by: Eric Anholt <eric@anholt.net>
Signed-off-by: Dave Airlie <airlied@redhat.com>
  • Loading branch information
Zhenyu Wang authored and Dave Airlie committed Oct 23, 2008
1 parent d1ed629 commit 786225e
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions drivers/gpu/drm/drm_drawable.c
Original file line number Diff line number Diff line change
Expand Up @@ -76,11 +76,14 @@ int drm_rmdraw(struct drm_device *dev, void *data, struct drm_file *file_priv)
{
struct drm_draw *draw = data;
unsigned long irqflags;
struct drm_drawable_info *info;

spin_lock_irqsave(&dev->drw_lock, irqflags);

drm_free(drm_get_drawable_info(dev, draw->handle),
sizeof(struct drm_drawable_info), DRM_MEM_BUFS);
info = drm_get_drawable_info(dev, draw->handle);
drm_free(info->rects, info->num_rects * sizeof(struct drm_clip_rect),
DRM_MEM_BUFS);
drm_free(info, sizeof(struct drm_drawable_info), DRM_MEM_BUFS);

idr_remove(&dev->drw_idr, draw->handle);

Expand Down

0 comments on commit 786225e

Please sign in to comment.