Skip to content

Commit

Permalink
ext4: don't lock the next page in write_cache_pages if not needed
Browse files Browse the repository at this point in the history
If we have accumulated a contiguous region of memory to be written
out, and the next page can added to this region, don't bother locking
(and then unlocking the page) before writing out the memory.  In the
unlikely event that the next page was being written back by some other
CPU, we can also skip waiting that page to finish writeback.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
  • Loading branch information
Theodore Ts'o committed Feb 26, 2011
1 parent ee6ecbc commit 78aaced
Showing 1 changed file with 10 additions and 17 deletions.
27 changes: 10 additions & 17 deletions fs/ext4/inode.c
Original file line number Diff line number Diff line change
Expand Up @@ -2761,6 +2761,16 @@ static int write_cache_pages_da(struct address_space *mapping,

*done_index = page->index + 1;

/*
* If we can't merge this page, and we have
* accumulated an contiguous region, write it
*/
if ((mpd->next_page != page->index) &&
(mpd->next_page != mpd->first_page)) {
mpage_da_map_and_submit(mpd);
goto ret_extent_tail;
}

lock_page(page);

/*
Expand All @@ -2784,24 +2794,7 @@ static int write_cache_pages_da(struct address_space *mapping,

BUG_ON(PageWriteback(page));

/*
* Can we merge this page to current extent?
*/
if (mpd->next_page != page->index) {
/*
* Nope, we can't. So, we map
* non-allocated blocks and start IO
* on them
*/
if (mpd->next_page != mpd->first_page) {
mpage_da_map_and_submit(mpd);
/*
* skip rest of the page in the page_vec
*/
unlock_page(page);
goto ret_extent_tail;
}

/*
* Start next extent of pages and blocks
*/
Expand Down

0 comments on commit 78aaced

Please sign in to comment.