Skip to content

Commit

Permalink
Staging: bcm: Bcmchar: Fix some checkpatch errors
Browse files Browse the repository at this point in the history
Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Javier Martinez Canillas authored and Greg Kroah-Hartman committed Feb 18, 2011
1 parent 7227ba0 commit 78acd58
Showing 1 changed file with 10 additions and 10 deletions.
20 changes: 10 additions & 10 deletions drivers/staging/bcm/Bcmchar.c
Original file line number Diff line number Diff line change
Expand Up @@ -2100,7 +2100,7 @@ static long bcm_char_ioctl(struct file *filp, UINT cmd, ULONG arg)
}


static struct file_operations bcm_fops = {
static const struct file_operations bcm_fops = {
.owner = THIS_MODULE,
.open = bcm_char_open,
.release = bcm_char_release,
Expand All @@ -2114,32 +2114,32 @@ extern struct class *bcm_class;
int register_control_device_interface(PMINI_ADAPTER Adapter)
{

if(Adapter->major>0)
if (Adapter->major > 0)
return Adapter->major;

Adapter->major = register_chrdev(0, DEV_NAME, &bcm_fops);
if(Adapter->major < 0) {
if (Adapter->major < 0) {
pr_err(DRV_NAME ": could not created character device\n");
return Adapter->major;
}

Adapter->pstCreatedClassDevice = device_create (bcm_class, NULL,
MKDEV(Adapter->major, 0), Adapter,
DEV_NAME);
Adapter->pstCreatedClassDevice = device_create(bcm_class, NULL,
MKDEV(Adapter->major, 0),
Adapter, DEV_NAME);

if(IS_ERR(Adapter->pstCreatedClassDevice)) {
if (IS_ERR(Adapter->pstCreatedClassDevice)) {
pr_err(DRV_NAME ": class device create failed\n");
unregister_chrdev(Adapter->major, DEV_NAME);
return PTR_ERR(Adapter->pstCreatedClassDevice);
}

return 0;
}

void unregister_control_device_interface(PMINI_ADAPTER Adapter)
{
if(Adapter->major > 0) {
device_destroy (bcm_class, MKDEV(Adapter->major, 0));
if (Adapter->major > 0) {
device_destroy(bcm_class, MKDEV(Adapter->major, 0));
unregister_chrdev(Adapter->major, DEV_NAME);
}
}

0 comments on commit 78acd58

Please sign in to comment.