Skip to content

Commit

Permalink
IPoIB: Take dev->xmit_lock around mc_list accesses
Browse files Browse the repository at this point in the history
dev->mc_list accesses must be protected by dev->xmit_lock.
Found by Eli Cohen <eli@mellanox.co.il>.

Signed-off-by: Michael S. Tsirkin <mst@mellanox.co.il>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
  • Loading branch information
Michael S. Tsirkin authored and Roland Dreier committed Jan 11, 2006
1 parent 97460df commit 78bfe0b
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions drivers/infiniband/ulp/ipoib/ipoib_multicast.c
Original file line number Diff line number Diff line change
Expand Up @@ -827,7 +827,8 @@ void ipoib_mcast_restart_task(void *dev_ptr)

ipoib_mcast_stop_thread(dev, 0);

spin_lock_irqsave(&priv->lock, flags);
spin_lock_irqsave(&dev->xmit_lock, flags);
spin_lock(&priv->lock);

/*
* Unfortunately, the networking core only gives us a list of all of
Expand Down Expand Up @@ -899,7 +900,9 @@ void ipoib_mcast_restart_task(void *dev_ptr)
list_add_tail(&mcast->list, &remove_list);
}
}
spin_unlock_irqrestore(&priv->lock, flags);

spin_unlock(&priv->lock);
spin_unlock_irqrestore(&dev->xmit_lock, flags);

/* We have to cancel outside of the spinlock */
list_for_each_entry_safe(mcast, tmcast, &remove_list, list) {
Expand Down

0 comments on commit 78bfe0b

Please sign in to comment.