Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 231661
b: refs/heads/master
c: ecf5632
h: refs/heads/master
i:
  231659: 89ef2d4
v: v3
  • Loading branch information
Namhyung Kim authored and Al Viro committed Jan 17, 2011
1 parent 2e4193d commit 78d6699
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 27eaa1c90c608aa907336c2743d5ecf35c469440
refs/heads/master: ecf5632dd189ab4c366cef853d6e5fe7adfe52e5
10 changes: 5 additions & 5 deletions trunk/fs/ioctl.c
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ int fiemap_fill_next_extent(struct fiemap_extent_info *fieinfo, u64 logical,
u64 phys, u64 len, u32 flags)
{
struct fiemap_extent extent;
struct fiemap_extent *dest = fieinfo->fi_extents_start;
struct fiemap_extent __user *dest = fieinfo->fi_extents_start;

/* only count the extents */
if (fieinfo->fi_extents_max == 0) {
Expand Down Expand Up @@ -173,6 +173,7 @@ static int fiemap_check_ranges(struct super_block *sb,
static int ioctl_fiemap(struct file *filp, unsigned long arg)
{
struct fiemap fiemap;
struct fiemap __user *ufiemap = (struct fiemap __user *) arg;
struct fiemap_extent_info fieinfo = { 0, };
struct inode *inode = filp->f_path.dentry->d_inode;
struct super_block *sb = inode->i_sb;
Expand All @@ -182,8 +183,7 @@ static int ioctl_fiemap(struct file *filp, unsigned long arg)
if (!inode->i_op->fiemap)
return -EOPNOTSUPP;

if (copy_from_user(&fiemap, (struct fiemap __user *)arg,
sizeof(struct fiemap)))
if (copy_from_user(&fiemap, ufiemap, sizeof(fiemap)))
return -EFAULT;

if (fiemap.fm_extent_count > FIEMAP_MAX_EXTENTS)
Expand All @@ -196,7 +196,7 @@ static int ioctl_fiemap(struct file *filp, unsigned long arg)

fieinfo.fi_flags = fiemap.fm_flags;
fieinfo.fi_extents_max = fiemap.fm_extent_count;
fieinfo.fi_extents_start = (struct fiemap_extent *)(arg + sizeof(fiemap));
fieinfo.fi_extents_start = ufiemap->fm_extents;

if (fiemap.fm_extent_count != 0 &&
!access_ok(VERIFY_WRITE, fieinfo.fi_extents_start,
Expand All @@ -209,7 +209,7 @@ static int ioctl_fiemap(struct file *filp, unsigned long arg)
error = inode->i_op->fiemap(inode, &fieinfo, fiemap.fm_start, len);
fiemap.fm_flags = fieinfo.fi_flags;
fiemap.fm_mapped_extents = fieinfo.fi_extents_mapped;
if (copy_to_user((char *)arg, &fiemap, sizeof(fiemap)))
if (copy_to_user(ufiemap, &fiemap, sizeof(fiemap)))
error = -EFAULT;

return error;
Expand Down
4 changes: 2 additions & 2 deletions trunk/include/linux/fs.h
Original file line number Diff line number Diff line change
Expand Up @@ -1483,8 +1483,8 @@ struct fiemap_extent_info {
unsigned int fi_flags; /* Flags as passed from user */
unsigned int fi_extents_mapped; /* Number of mapped extents */
unsigned int fi_extents_max; /* Size of fiemap_extent array */
struct fiemap_extent *fi_extents_start; /* Start of fiemap_extent
* array */
struct fiemap_extent __user *fi_extents_start; /* Start of
fiemap_extent array */
};
int fiemap_fill_next_extent(struct fiemap_extent_info *info, u64 logical,
u64 phys, u64 len, u32 flags);
Expand Down

0 comments on commit 78d6699

Please sign in to comment.