Skip to content

Commit

Permalink
[PATCH] minix: switch to inode_inc_link_count, inode_dec_link_count
Browse files Browse the repository at this point in the history
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Alexey Dobriyan authored and Linus Torvalds committed Mar 23, 2006
1 parent 66d2173 commit 78ec7b6
Showing 1 changed file with 18 additions and 30 deletions.
48 changes: 18 additions & 30 deletions fs/minix/namei.c
Original file line number Diff line number Diff line change
Expand Up @@ -6,26 +6,14 @@

#include "minix.h"

static inline void inc_count(struct inode *inode)
{
inode->i_nlink++;
mark_inode_dirty(inode);
}

static inline void dec_count(struct inode *inode)
{
inode->i_nlink--;
mark_inode_dirty(inode);
}

static int add_nondir(struct dentry *dentry, struct inode *inode)
{
int err = minix_add_link(dentry, inode);
if (!err) {
d_instantiate(dentry, inode);
return 0;
}
dec_count(inode);
inode_dec_link_count(inode);
iput(inode);
return err;
}
Expand Down Expand Up @@ -125,7 +113,7 @@ static int minix_symlink(struct inode * dir, struct dentry *dentry,
return err;

out_fail:
dec_count(inode);
inode_dec_link_count(inode);
iput(inode);
goto out;
}
Expand All @@ -139,7 +127,7 @@ static int minix_link(struct dentry * old_dentry, struct inode * dir,
return -EMLINK;

inode->i_ctime = CURRENT_TIME_SEC;
inc_count(inode);
inode_inc_link_count(inode);
atomic_inc(&inode->i_count);
return add_nondir(dentry, inode);
}
Expand All @@ -152,7 +140,7 @@ static int minix_mkdir(struct inode * dir, struct dentry *dentry, int mode)
if (dir->i_nlink >= minix_sb(dir->i_sb)->s_link_max)
goto out;

inc_count(dir);
inode_inc_link_count(dir);

inode = minix_new_inode(dir, &err);
if (!inode)
Expand All @@ -163,7 +151,7 @@ static int minix_mkdir(struct inode * dir, struct dentry *dentry, int mode)
inode->i_mode |= S_ISGID;
minix_set_inode(inode, 0);

inc_count(inode);
inode_inc_link_count(inode);

err = minix_make_empty(inode, dir);
if (err)
Expand All @@ -178,11 +166,11 @@ static int minix_mkdir(struct inode * dir, struct dentry *dentry, int mode)
return err;

out_fail:
dec_count(inode);
dec_count(inode);
inode_dec_link_count(inode);
inode_dec_link_count(inode);
iput(inode);
out_dir:
dec_count(dir);
inode_dec_link_count(dir);
goto out;
}

Expand All @@ -202,7 +190,7 @@ static int minix_unlink(struct inode * dir, struct dentry *dentry)
goto end_unlink;

inode->i_ctime = dir->i_ctime;
dec_count(inode);
inode_dec_link_count(inode);
end_unlink:
return err;
}
Expand All @@ -215,8 +203,8 @@ static int minix_rmdir(struct inode * dir, struct dentry *dentry)
if (minix_empty_dir(inode)) {
err = minix_unlink(dir, dentry);
if (!err) {
dec_count(dir);
dec_count(inode);
inode_dec_link_count(dir);
inode_dec_link_count(inode);
}
}
return err;
Expand Down Expand Up @@ -257,34 +245,34 @@ static int minix_rename(struct inode * old_dir, struct dentry *old_dentry,
new_de = minix_find_entry(new_dentry, &new_page);
if (!new_de)
goto out_dir;
inc_count(old_inode);
inode_inc_link_count(old_inode);
minix_set_link(new_de, new_page, old_inode);
new_inode->i_ctime = CURRENT_TIME_SEC;
if (dir_de)
new_inode->i_nlink--;
dec_count(new_inode);
inode_dec_link_count(new_inode);
} else {
if (dir_de) {
err = -EMLINK;
if (new_dir->i_nlink >= info->s_link_max)
goto out_dir;
}
inc_count(old_inode);
inode_inc_link_count(old_inode);
err = minix_add_link(new_dentry, old_inode);
if (err) {
dec_count(old_inode);
inode_dec_link_count(old_inode);
goto out_dir;
}
if (dir_de)
inc_count(new_dir);
inode_inc_link_count(new_dir);
}

minix_delete_entry(old_de, old_page);
dec_count(old_inode);
inode_dec_link_count(old_inode);

if (dir_de) {
minix_set_link(dir_de, dir_page, new_dir);
dec_count(old_dir);
inode_dec_link_count(old_dir);
}
return 0;

Expand Down

0 comments on commit 78ec7b6

Please sign in to comment.