Skip to content

Commit

Permalink
tty: serial: msm_serial: Don't require DT aliases
Browse files Browse the repository at this point in the history
If there isn't a DT alias then of_alias_get_id() will return
-ENODEV. This will cause the msm_serial driver to fail probe,
when we want to keep the previous behavior where we generated a
dynamic line number at probe time. Restore this behavior by
generating a dynamic id if the line number is still negative
after checking for an alias or in the non-DT case looking at the
.id field of the platform device.

Reported-by: Kevin Hilman <khilman@kernel.org>
Tested-by: Kevin Hilman <khilman@linaro.org>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Stephen Boyd authored and Greg Kroah-Hartman committed Nov 24, 2014
1 parent 52c40fc commit 7920408
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions drivers/tty/serial/msm_serial.c
Original file line number Diff line number Diff line change
Expand Up @@ -1046,14 +1046,14 @@ static int msm_serial_probe(struct platform_device *pdev)
const struct of_device_id *id;
int irq, line;

if (pdev->id == -1)
pdev->id = atomic_inc_return(&msm_uart_next_id) - 1;

if (pdev->dev.of_node)
line = of_alias_get_id(pdev->dev.of_node, "serial");
else
line = pdev->id;

if (line < 0)
line = atomic_inc_return(&msm_uart_next_id) - 1;

if (unlikely(line < 0 || line >= UART_NR))
return -ENXIO;

Expand Down

0 comments on commit 7920408

Please sign in to comment.