Skip to content

Commit

Permalink
bql: Fix inconsistency between file mode and attr method.
Browse files Browse the repository at this point in the history
There is no store() method for inflight attribute in the
tx-<n>/byte_queue_limits sysfs directory.
So remove S_IWUSR bit.

Signed-off-by: Hiroaki SHIMODA <shimoda.hiroaki@gmail.com>
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Hiroaki SHIMODA authored and David S. Miller committed Jan 17, 2012
1 parent 1886e5d commit 795d9a2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/core/net-sysfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -929,7 +929,7 @@ static ssize_t bql_show_inflight(struct netdev_queue *queue,
}

static struct netdev_queue_attribute bql_inflight_attribute =
__ATTR(inflight, S_IRUGO | S_IWUSR, bql_show_inflight, NULL);
__ATTR(inflight, S_IRUGO, bql_show_inflight, NULL);

#define BQL_ATTR(NAME, FIELD) \
static ssize_t bql_show_ ## NAME(struct netdev_queue *queue, \
Expand Down

0 comments on commit 795d9a2

Please sign in to comment.