Skip to content

Commit

Permalink
ceph: only set num_pages in calc_layout
Browse files Browse the repository at this point in the history
Setting it elsewhere is unnecessary and more fragile.

Signed-off-by: Sage Weil <sage@newdream.net>
  • Loading branch information
Sage Weil committed Aug 2, 2010
1 parent 3715166 commit 796d695
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions fs/ceph/osd_client.c
Original file line number Diff line number Diff line change
Expand Up @@ -1276,8 +1276,6 @@ int ceph_osdc_readpages(struct ceph_osd_client *osdc,

/* it may be a short read due to an object boundary */
req->r_pages = pages;
num_pages = calc_pages_for(off, *plen);
req->r_num_pages = num_pages;

dout("readpages final extent is %llu~%llu (%d pages)\n",
off, *plen, req->r_num_pages);
Expand Down Expand Up @@ -1319,7 +1317,6 @@ int ceph_osdc_writepages(struct ceph_osd_client *osdc, struct ceph_vino vino,

/* it may be a short write due to an object boundary */
req->r_pages = pages;
req->r_num_pages = calc_pages_for(off, len);
dout("writepages %llu~%llu (%d pages)\n", off, len,
req->r_num_pages);

Expand Down

0 comments on commit 796d695

Please sign in to comment.