Skip to content

Commit

Permalink
staging: comedi: remove this_board macro in the aio_aio12_8 driver
Browse files Browse the repository at this point in the history
The 'thisboard' macro depends on having a local variable with
a magic name. The CodingStyle document suggests not doing this
to avoid confusion. Remove the macro and use the comedi_board()
inline helper to get the dev->board_ptr information.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
H Hartley Sweeten authored and Greg Kroah-Hartman committed Jun 5, 2012
1 parent b740554 commit 797ef32
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions drivers/staging/comedi/drivers/aio_aio12_8.c
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,6 @@ static const struct aio12_8_boardtype board_types[] = {
.name = "aio_aio12_8"},
};

#define thisboard ((const struct aio12_8_boardtype *) dev->board_ptr)

struct aio12_8_private {
unsigned int ao_readback[4];
};
Expand Down Expand Up @@ -167,6 +165,7 @@ static const struct comedi_lrange range_aio_aio12_8 = {
static int aio_aio12_8_attach(struct comedi_device *dev,
struct comedi_devconfig *it)
{
const struct aio12_8_boardtype *board = comedi_board(dev);
int iobase;
struct comedi_subdevice *s;

Expand All @@ -176,7 +175,7 @@ static int aio_aio12_8_attach(struct comedi_device *dev,
return -EIO;
}

dev->board_name = thisboard->name;
dev->board_name = board->name;

dev->iobase = iobase;

Expand Down

0 comments on commit 797ef32

Please sign in to comment.