Skip to content

Commit

Permalink
[media] via-camera: pass correct format settings to sensor
Browse files Browse the repository at this point in the history
The code attempts to maintain a "user format" and a "sensor format",
but in this case it looks like a typo is passing the user format down
to the sensor.

This was preventing display of video at anything other than 640x480.

Signed-off-by: Daniel Drake <dsd@laptop.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Daniel Drake authored and Mauro Carvalho Chehab committed Jul 31, 2012
1 parent fc4b3fa commit 7980a4d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/media/video/via-camera.c
Original file line number Diff line number Diff line change
Expand Up @@ -963,7 +963,7 @@ static int viacam_do_try_fmt(struct via_camera *cam,

upix->pixelformat = f->pixelformat;
viacam_fmt_pre(upix, spix);
v4l2_fill_mbus_format(&mbus_fmt, upix, f->mbus_code);
v4l2_fill_mbus_format(&mbus_fmt, spix, f->mbus_code);
ret = sensor_call(cam, video, try_mbus_fmt, &mbus_fmt);
v4l2_fill_pix_format(spix, &mbus_fmt);
viacam_fmt_post(upix, spix);
Expand Down

0 comments on commit 7980a4d

Please sign in to comment.