Skip to content

Commit

Permalink
ARM: ux500: List DT compatibility using platform names rather than by…
Browse files Browse the repository at this point in the history
… board

So far, each ST-Ericsson board supported by Device Tree has been similar
enough to run though a single DT_MACHINE_INIT call. On the back of that
it has been suggested that we should reduce the number of compatible
strings in our dt_compat structure. After subsequent discussion with Arnd
Bergmann the conclusion was to list entries by platform as opposed to by
board.

The other suggestion was to use a single string which would cover all
supported platforms, but any wildcard entries would include unsupported
chipsets, such as the u5500 and potential new chips which no not yet have
DT functionality. Hence, the best solution which encompasses all supported
platforms, but no unsupported ones was to list the currently enabled four
chipsets; u8500, u8540, u9500 and u9540 instead.

Acked-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
  • Loading branch information
Lee Jones committed Nov 1, 2012
1 parent 46c1bf8 commit 79b4075
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion arch/arm/boot/dts/ccu9540.dts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

/ {
model = "ST-Ericsson CCU9540 platform with Device Tree";
compatible = "st-ericsson,ccu9540";
compatible = "st-ericsson,ccu9540", "st-ericsson,u9540";

memory {
reg = <0x00000000 0x20000000>;
Expand Down
2 changes: 1 addition & 1 deletion arch/arm/boot/dts/hrefprev60.dts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

/ {
model = "ST-Ericsson HREF (pre-v60) platform with Device Tree";
compatible = "st-ericsson,mop500";
compatible = "st-ericsson,mop500", "st-ericsson,u8500";

gpio_keys {
button@1 {
Expand Down
2 changes: 1 addition & 1 deletion arch/arm/boot/dts/hrefv60plus.dts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

/ {
model = "ST-Ericsson HREF (v60+) platform with Device Tree";
compatible = "st-ericsson,hrefv60+";
compatible = "st-ericsson,hrefv60+", "st-ericsson,u8500";

gpio_keys {
button@1 {
Expand Down
2 changes: 1 addition & 1 deletion arch/arm/boot/dts/snowball.dts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

/ {
model = "Calao Systems Snowball platform with device tree";
compatible = "calaosystems,snowball-a9500";
compatible = "calaosystems,snowball-a9500", "st-ericsson,u9500";

memory {
reg = <0x00000000 0x20000000>;
Expand Down
12 changes: 6 additions & 6 deletions arch/arm/mach-ux500/cpu-db8500.c
Original file line number Diff line number Diff line change
Expand Up @@ -330,11 +330,11 @@ static void __init u8500_init_machine(void)
of_platform_populate(NULL, u8500_local_bus_nodes, u8500_auxdata_lookup, parent);
}

static const char * u8500_dt_board_compat[] = {
"calaosystems,snowball-a9500",
"st-ericsson,hrefv60+",
"st-ericsson,mop500",
"st-ericsson,ccu9540",
static const char * stericsson_dt_platform_compat[] = {
"st-ericsson,u8500",
"st-ericsson,u8540",
"st-ericsson,u9500",
"st-ericsson,u9540",
NULL,
};

Expand All @@ -346,7 +346,7 @@ DT_MACHINE_START(U8500_DT, "ST-Ericsson Ux5x0 platform (Device Tree Support)")
.handle_irq = gic_handle_irq,
.init_machine = u8500_init_machine,
.init_late = NULL,
.dt_compat = u8500_dt_board_compat,
.dt_compat = stericsson_dt_platform_compat,
MACHINE_END

#endif

0 comments on commit 79b4075

Please sign in to comment.