Skip to content

Commit

Permalink
ocfs2: delete redundant memcmp()
Browse files Browse the repository at this point in the history
This patch deletes redundant memcmp() while looking up in rb tree.

Signed-off-by: Akinbou Mita <akinobu.mita@gmail.com>
Signed-off-by: Mark Fasheh <mark.fasheh@oracle.com>
  • Loading branch information
Akinobu Mita authored and Mark Fasheh committed Oct 20, 2006
1 parent f1877fb commit 79cd22d
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions fs/ocfs2/cluster/nodemanager.c
Original file line number Diff line number Diff line change
Expand Up @@ -152,14 +152,16 @@ static struct o2nm_node *o2nm_node_ip_tree_lookup(struct o2nm_cluster *cluster,
struct o2nm_node *node, *ret = NULL;

while (*p) {
int cmp;

parent = *p;
node = rb_entry(parent, struct o2nm_node, nd_ip_node);

if (memcmp(&ip_needle, &node->nd_ipv4_address,
sizeof(ip_needle)) < 0)
cmp = memcmp(&ip_needle, &node->nd_ipv4_address,
sizeof(ip_needle));
if (cmp < 0)
p = &(*p)->rb_left;
else if (memcmp(&ip_needle, &node->nd_ipv4_address,
sizeof(ip_needle)) > 0)
else if (cmp > 0)
p = &(*p)->rb_right;
else {
ret = node;
Expand Down

0 comments on commit 79cd22d

Please sign in to comment.