Skip to content

Commit

Permalink
[PATCH] arm: add comment about dma_supported()
Browse files Browse the repository at this point in the history
)


From: Russell King <rmk+lkml@arm.linux.org.uk>

The ARM dma_supported() is rather basic, and I don't think it takes into
account everything that it should do (eg, whether the mask agrees with what
we'd return for GFP_DMA allocations).  Note this.

Signed-off-by: Russell King <rmk@arm.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
akpm@osdl.org authored and Linus Torvalds committed Apr 16, 2005
1 parent 7aa52f5 commit 7a228aa
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions include/asm-arm/dma-mapping.h
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ extern void consistent_sync(void *kaddr, size_t size, int rw);
* properly. For example, if your device can only drive the low 24-bits
* during bus mastering, then you would pass 0x00ffffff as the mask
* to this function.
*
* FIXME: This should really be a platform specific issue - we should
* return false if GFP_DMA allocations may not satisfy the supplied 'mask'.
*/
static inline int dma_supported(struct device *dev, u64 mask)
{
Expand Down

0 comments on commit 7a228aa

Please sign in to comment.