Skip to content

Commit

Permalink
virtio: console: remove_port() should return void
Browse files Browse the repository at this point in the history
When a port is removed, we have to assume the port is gone. So a
success/failure return value doesn't make sense.

Signed-off-by: Amit Shah <amit.shah@redhat.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
  • Loading branch information
Amit Shah authored and Rusty Russell committed Oct 21, 2010
1 parent f402811 commit 7a28531
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/char/virtio_console.c
Original file line number Diff line number Diff line change
Expand Up @@ -1131,7 +1131,7 @@ static int add_port(struct ports_device *portdev, u32 id)
}

/* Remove all port-specific data. */
static int remove_port(struct port *port)
static void remove_port(struct port *port)
{
struct port_buffer *buf;

Expand Down Expand Up @@ -1181,7 +1181,6 @@ static int remove_port(struct port *port)
debugfs_remove(port->debugfs_file);

kfree(port);
return 0;
}

/* Any private messages that the Host and Guest want to share */
Expand Down

0 comments on commit 7a28531

Please sign in to comment.