Skip to content

Commit

Permalink
Bluetooth: Fix refcount balance for hci connection
Browse files Browse the repository at this point in the history
hci_io_capa_reply_evt() holds reference for hciconnection. It's useless since
hci_io_capa_request_evt()/hci_simple_pair_complete_evt() already protects the
connection. In addition it leaves connection open after failed SSP pairing.

Signed-off-by: Ville Tervo <ville.tervo@nokia.com>
Signed-off-by: Gustavo F. Padovan <padovan@profusion.mobi>
  • Loading branch information
Ville Tervo authored and Gustavo F. Padovan committed Apr 18, 2011
1 parent 332704a commit 7a74aeb
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions net/bluetooth/hci_event.c
Original file line number Diff line number Diff line change
Expand Up @@ -2387,8 +2387,6 @@ static inline void hci_io_capa_reply_evt(struct hci_dev *hdev, struct sk_buff *s
if (!conn)
goto unlock;

hci_conn_hold(conn);

conn->remote_cap = ev->capability;
conn->remote_oob = ev->oob_data;
conn->remote_auth = ev->authentication;
Expand Down

0 comments on commit 7a74aeb

Please sign in to comment.