Skip to content

Commit

Permalink
[PATCH] libata: separate out sata_phy_resume() from sata_std_hardreset()
Browse files Browse the repository at this point in the history
This patch separates out sata_phy_resume() from sata_std_hardreset().
The function will later be used by probeinit callback.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
  • Loading branch information
Tejun Heo authored and Jeff Garzik committed Feb 9, 2006
1 parent b911fc3 commit 7a7921e
Showing 1 changed file with 21 additions and 11 deletions.
32 changes: 21 additions & 11 deletions drivers/scsi/libata-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -2277,6 +2277,24 @@ void ata_bus_reset(struct ata_port *ap)
DPRINTK("EXIT\n");
}

static int sata_phy_resume(struct ata_port *ap)
{
unsigned long timeout = jiffies + (HZ * 5);
u32 sstatus;

scr_write_flush(ap, SCR_CONTROL, 0x300);

/* Wait for phy to become ready, if necessary. */
do {
msleep(200);
sstatus = scr_read(ap, SCR_STATUS);
if ((sstatus & 0xf) != 1)
return 0;
} while (time_before(jiffies, timeout));

return -1;
}

/**
* ata_std_softreset - reset host port via ATA SRST
* @ap: port to reset
Expand Down Expand Up @@ -2357,8 +2375,7 @@ int ata_std_softreset(struct ata_port *ap, int verbose, unsigned int *classes)
*/
int sata_std_hardreset(struct ata_port *ap, int verbose, unsigned int *class)
{
u32 sstatus, serror;
unsigned long timeout = jiffies + (HZ * 5);
u32 serror;

DPRINTK("ENTER\n");

Expand All @@ -2371,15 +2388,8 @@ int sata_std_hardreset(struct ata_port *ap, int verbose, unsigned int *class)
*/
msleep(1);

scr_write_flush(ap, SCR_CONTROL, 0x300);

/* Wait for phy to become ready, if necessary. */
do {
msleep(200);
sstatus = scr_read(ap, SCR_STATUS);
if ((sstatus & 0xf) != 1)
break;
} while (time_before(jiffies, timeout));
/* Bring phy back */
sata_phy_resume(ap);

/* Clear SError */
serror = scr_read(ap, SCR_ERROR);
Expand Down

0 comments on commit 7a7921e

Please sign in to comment.