Skip to content

Commit

Permalink
[media] s5p-fimc: Fix initialization for proper system suspend support
Browse files Browse the repository at this point in the history
ST_LPM bit must not be initially set, so the first resume helper
call properly quiesce the device's operation.
Also fimc_runtime_suspend() at device remove is unneeded and
leads to unbalanced clock disable so remove it.

Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Sylwester Nawrocki authored and Mauro Carvalho Chehab committed Nov 24, 2011
1 parent 64c570f commit 7aa9f18
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/media/video/s5p-fimc/fimc-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -1615,7 +1615,6 @@ static int fimc_probe(struct platform_device *pdev)
pdata = pdev->dev.platform_data;
fimc->pdata = pdata;

set_bit(ST_LPM, &fimc->state);

init_waitqueue_head(&fimc->irq_queue);
spin_lock_init(&fimc->slock);
Expand Down Expand Up @@ -1780,7 +1779,6 @@ static int __devexit fimc_remove(struct platform_device *pdev)
struct fimc_dev *fimc = platform_get_drvdata(pdev);

pm_runtime_disable(&pdev->dev);
fimc_runtime_suspend(&pdev->dev);
pm_runtime_set_suspended(&pdev->dev);

vb2_dma_contig_cleanup_ctx(fimc->alloc_ctx);
Expand Down

0 comments on commit 7aa9f18

Please sign in to comment.