Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 175026
b: refs/heads/master
c: 06fc0d6
h: refs/heads/master
v: v3
  • Loading branch information
Eric W. Biederman authored and Greg Kroah-Hartman committed Dec 11, 2009
1 parent 4b46e2c commit 7ac4477
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 24 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: e61ab4ae48fbf477f5b9fcbec9e1b8dc789920d0
refs/heads/master: 06fc0d66f7ed3a3b08e8fcf8c325ecf0b8f93fea
31 changes: 8 additions & 23 deletions trunk/fs/sysfs/file.c
Original file line number Diff line number Diff line change
Expand Up @@ -579,38 +579,23 @@ EXPORT_SYMBOL_GPL(sysfs_add_file_to_group);
*/
int sysfs_chmod_file(struct kobject *kobj, struct attribute *attr, mode_t mode)
{
struct sysfs_dirent *victim_sd = NULL;
struct dentry *victim = NULL;
struct inode * inode;
struct sysfs_dirent *sd;
struct iattr newattrs;
int rc;

rc = -ENOENT;
victim_sd = sysfs_get_dirent(kobj->sd, attr->name);
if (!victim_sd)
goto out;
mutex_lock(&sysfs_mutex);

mutex_lock(&sysfs_rename_mutex);
victim = sysfs_get_dentry(victim_sd);
mutex_unlock(&sysfs_rename_mutex);
if (IS_ERR(victim)) {
rc = PTR_ERR(victim);
victim = NULL;
rc = -ENOENT;
sd = sysfs_find_dirent(kobj->sd, attr->name);
if (!sd)
goto out;
}

inode = victim->d_inode;

mutex_lock(&inode->i_mutex);

newattrs.ia_mode = (mode & S_IALLUGO) | (inode->i_mode & ~S_IALLUGO);
newattrs.ia_mode = (mode & S_IALLUGO) | (sd->s_mode & ~S_IALLUGO);
newattrs.ia_valid = ATTR_MODE;
rc = sysfs_setattr(victim, &newattrs);
rc = sysfs_sd_setattr(sd, &newattrs);

mutex_unlock(&inode->i_mutex);
out:
dput(victim);
sysfs_put(victim_sd);
mutex_unlock(&sysfs_mutex);
return rc;
}
EXPORT_SYMBOL_GPL(sysfs_chmod_file);
Expand Down

0 comments on commit 7ac4477

Please sign in to comment.