Skip to content

Commit

Permalink
[PATCH] ppc: Fix ARCH=ppc build with xmon
Browse files Browse the repository at this point in the history
xmon() prototype is inconsistent between ARCH=ppc and ARCH=powerpc,
thus causing ARCH=ppc build breakage.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Paul Mackerras <paulus@samba.org>
  • Loading branch information
Benjamin Herrenschmidt authored and Paul Mackerras committed Nov 8, 2005
1 parent 21fe330 commit 7b007de
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
4 changes: 2 additions & 2 deletions arch/ppc/kernel/traps.c
Original file line number Diff line number Diff line change
Expand Up @@ -49,15 +49,15 @@ extern int xmon_sstep(struct pt_regs *regs);
extern int xmon_iabr_match(struct pt_regs *regs);
extern int xmon_dabr_match(struct pt_regs *regs);

void (*debugger)(struct pt_regs *regs) = xmon;
int (*debugger)(struct pt_regs *regs) = xmon;
int (*debugger_bpt)(struct pt_regs *regs) = xmon_bpt;
int (*debugger_sstep)(struct pt_regs *regs) = xmon_sstep;
int (*debugger_iabr_match)(struct pt_regs *regs) = xmon_iabr_match;
int (*debugger_dabr_match)(struct pt_regs *regs) = xmon_dabr_match;
void (*debugger_fault_handler)(struct pt_regs *regs);
#else
#ifdef CONFIG_KGDB
void (*debugger)(struct pt_regs *regs);
int (*debugger)(struct pt_regs *regs);
int (*debugger_bpt)(struct pt_regs *regs);
int (*debugger_sstep)(struct pt_regs *regs);
int (*debugger_iabr_match)(struct pt_regs *regs);
Expand Down
5 changes: 3 additions & 2 deletions arch/ppc/xmon/xmon.c
Original file line number Diff line number Diff line change
Expand Up @@ -220,8 +220,7 @@ static void get_tb(unsigned *p)
p[1] = lo;
}

void
xmon(struct pt_regs *excp)
int xmon(struct pt_regs *excp)
{
struct pt_regs regs;
int msr, cmd;
Expand Down Expand Up @@ -290,6 +289,8 @@ xmon(struct pt_regs *excp)
#endif /* CONFIG_SMP */
set_msr(msr); /* restore interrupt enable */
get_tb(start_tb[smp_processor_id()]);

return cmd != 'X';
}

irqreturn_t
Expand Down
2 changes: 1 addition & 1 deletion include/asm-ppc/kgdb.h
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ extern void breakpoint(void);
/* For taking exceptions
* these are defined in traps.c
*/
extern void (*debugger)(struct pt_regs *regs);
extern int (*debugger)(struct pt_regs *regs);
extern int (*debugger_bpt)(struct pt_regs *regs);
extern int (*debugger_sstep)(struct pt_regs *regs);
extern int (*debugger_iabr_match)(struct pt_regs *regs);
Expand Down

0 comments on commit 7b007de

Please sign in to comment.