Skip to content

Commit

Permalink
ARM: OMAP: USB: fix warning on EHCI PHY reset path
Browse files Browse the repository at this point in the history
When PHY reset pin is connected to a GPIO on external GPIO chip
(e.g. I2C), we should not call the gpio_set_value() function, but
gpio_set_value_cansleep().

Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
Acked-by: Felipe Balbi <balbi@ti.com>
Tested-by: Govindraj.R <govindraj.raja@ti.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Igor Grinberg authored and Greg Kroah-Hartman committed May 9, 2012
1 parent 1f339d8 commit 7b18389
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/usb/host/ehci-omap.c
Original file line number Diff line number Diff line change
Expand Up @@ -249,10 +249,10 @@ static int ehci_hcd_omap_probe(struct platform_device *pdev)
udelay(10);

if (gpio_is_valid(pdata->reset_gpio_port[0]))
gpio_set_value(pdata->reset_gpio_port[0], 1);
gpio_set_value_cansleep(pdata->reset_gpio_port[0], 1);

if (gpio_is_valid(pdata->reset_gpio_port[1]))
gpio_set_value(pdata->reset_gpio_port[1], 1);
gpio_set_value_cansleep(pdata->reset_gpio_port[1], 1);
}

ret = usb_add_hcd(hcd, irq, IRQF_SHARED);
Expand Down

0 comments on commit 7b18389

Please sign in to comment.