Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 295259
b: refs/heads/master
c: aa9147c
h: refs/heads/master
i:
  295257: 60ea0a5
  295255: 346dd81
v: v3
  • Loading branch information
Denys Vlasenko authored and Linus Torvalds committed Mar 23, 2012
1 parent 06d0679 commit 7b1d19c
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 11 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 86b6c1f301faf085de5a3f9ce16b8de6e69c729b
refs/heads/master: aa9147c98f27550bd39416eca5a5844e54bced26
31 changes: 21 additions & 10 deletions trunk/kernel/ptrace.c
Original file line number Diff line number Diff line change
Expand Up @@ -231,26 +231,37 @@ bool ptrace_may_access(struct task_struct *task, unsigned int mode)
}

static int ptrace_attach(struct task_struct *task, long request,
unsigned long addr,
unsigned long flags)
{
bool seize = (request == PTRACE_SEIZE);
int retval;

/*
* SEIZE will enable new ptrace behaviors which will be implemented
* gradually. SEIZE_DEVEL is used to prevent applications
* gradually. SEIZE_DEVEL bit is used to prevent applications
* expecting full SEIZE behaviors trapping on kernel commits which
* are still in the process of implementing them.
*
* Only test programs for new ptrace behaviors being implemented
* should set SEIZE_DEVEL. If unset, SEIZE will fail with -EIO.
*
* Once SEIZE behaviors are completely implemented, this flag and
* the following test will be removed.
* Once SEIZE behaviors are completely implemented, this flag
* will be removed.
*/
retval = -EIO;
if (seize && !(flags & PTRACE_SEIZE_DEVEL))
goto out;
if (seize) {
if (addr != 0)
goto out;
if (!(flags & PTRACE_SEIZE_DEVEL))
goto out;
flags &= ~(unsigned long)PTRACE_SEIZE_DEVEL;
if (flags & ~(unsigned long)PTRACE_O_MASK)
goto out;
flags = PT_PTRACED | PT_SEIZED | (flags << PT_OPT_FLAG_SHIFT);
} else {
flags = PT_PTRACED;
}

audit_ptrace(task);

Expand Down Expand Up @@ -282,11 +293,11 @@ static int ptrace_attach(struct task_struct *task, long request,
if (task->ptrace)
goto unlock_tasklist;

task->ptrace = PT_PTRACED;
if (seize)
task->ptrace |= PT_SEIZED;
flags |= PT_SEIZED;
if (ns_capable(task_user_ns(task), CAP_SYS_PTRACE))
task->ptrace |= PT_PTRACE_CAP;
flags |= PT_PTRACE_CAP;
task->ptrace = flags;

__ptrace_link(task, current);

Expand Down Expand Up @@ -879,7 +890,7 @@ SYSCALL_DEFINE4(ptrace, long, request, long, pid, unsigned long, addr,
}

if (request == PTRACE_ATTACH || request == PTRACE_SEIZE) {
ret = ptrace_attach(child, request, data);
ret = ptrace_attach(child, request, addr, data);
/*
* Some architectures need to do book-keeping after
* a ptrace attach.
Expand Down Expand Up @@ -1022,7 +1033,7 @@ asmlinkage long compat_sys_ptrace(compat_long_t request, compat_long_t pid,
}

if (request == PTRACE_ATTACH || request == PTRACE_SEIZE) {
ret = ptrace_attach(child, request, data);
ret = ptrace_attach(child, request, addr, data);
/*
* Some architectures need to do book-keeping after
* a ptrace attach.
Expand Down

0 comments on commit 7b1d19c

Please sign in to comment.