Skip to content

Commit

Permalink
[PATCH] m68k: fix cmpxchg compile errors if CONFIG_RMW_INSNS=n
Browse files Browse the repository at this point in the history
We require that all archs implement atomic_cmpxchg(), for the generic
version of atomic_add_unless().

Signed-off-by: Roman Zippel <zippel@linux-m68k.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Roman Zippel authored and Linus Torvalds committed Mar 10, 2006
1 parent b707dbe commit 7b61fcd
Showing 1 changed file with 32 additions and 3 deletions.
35 changes: 32 additions & 3 deletions include/asm-m68k/atomic.h
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ static inline int atomic_inc_and_test(atomic_t *v)
}

#ifdef CONFIG_RMW_INSNS

static inline int atomic_add_return(int i, atomic_t *v)
{
int t, tmp;
Expand Down Expand Up @@ -82,7 +83,12 @@ static inline int atomic_sub_return(int i, atomic_t *v)
: "g" (i), "2" (atomic_read(v)));
return t;
}

#define atomic_cmpxchg(v, o, n) ((int)cmpxchg(&((v)->counter), (o), (n)))
#define atomic_xchg(v, new) (xchg(&((v)->counter), new))

#else /* !CONFIG_RMW_INSNS */

static inline int atomic_add_return(int i, atomic_t * v)
{
unsigned long flags;
Expand Down Expand Up @@ -110,6 +116,32 @@ static inline int atomic_sub_return(int i, atomic_t * v)

return t;
}

static inline int atomic_cmpxchg(atomic_t *v, int old, int new)
{
unsigned long flags;
int prev;

local_irq_save(flags);
prev = atomic_read(v);
if (prev == old)
atomic_set(v, new);
local_irq_restore(flags);
return prev;
}

static inline int atomic_xchg(atomic_t *v, int new)
{
unsigned long flags;
int prev;

local_irq_save(flags);
prev = atomic_read(v);
atomic_set(v, new);
local_irq_restore(flags);
return prev;
}

#endif /* !CONFIG_RMW_INSNS */

#define atomic_dec_return(v) atomic_sub_return(1, (v))
Expand Down Expand Up @@ -139,9 +171,6 @@ static inline void atomic_set_mask(unsigned long mask, unsigned long *v)
__asm__ __volatile__("orl %1,%0" : "+m" (*v) : "id" (mask));
}

#define atomic_cmpxchg(v, o, n) ((int)cmpxchg(&((v)->counter), (o), (n)))
#define atomic_xchg(v, new) (xchg(&((v)->counter), new))

#define atomic_add_unless(v, a, u) \
({ \
int c, old; \
Expand Down

0 comments on commit 7b61fcd

Please sign in to comment.