Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 283922
b: refs/heads/master
c: 2fa3349
h: refs/heads/master
v: v3
  • Loading branch information
Mark Brown committed Dec 12, 2011
1 parent 9c33d61 commit 7b70267
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 12 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: cf763c2e606e9e427ed854c470911e816be1101e
refs/heads/master: 2fa33494676636f3455daddda33b7c3d5d932f2f
16 changes: 5 additions & 11 deletions trunk/drivers/mfd/wm8994-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -401,9 +401,9 @@ static int wm8994_device_init(struct wm8994 *wm8994, int irq)
goto err_regmap;
}

wm8994->supplies = kzalloc(sizeof(struct regulator_bulk_data) *
wm8994->num_supplies,
GFP_KERNEL);
wm8994->supplies = devm_kzalloc(wm8994->dev,
sizeof(struct regulator_bulk_data) *
wm8994->num_supplies, GFP_KERNEL);
if (!wm8994->supplies) {
ret = -ENOMEM;
goto err_regmap;
Expand Down Expand Up @@ -431,7 +431,7 @@ static int wm8994_device_init(struct wm8994 *wm8994, int irq)
wm8994->supplies);
if (ret != 0) {
dev_err(wm8994->dev, "Failed to get supplies: %d\n", ret);
goto err_supplies;
goto err_regmap;
}

ret = regulator_bulk_enable(wm8994->num_supplies,
Expand Down Expand Up @@ -559,12 +559,9 @@ static int wm8994_device_init(struct wm8994 *wm8994, int irq)
wm8994->supplies);
err_get:
regulator_bulk_free(wm8994->num_supplies, wm8994->supplies);
err_supplies:
kfree(wm8994->supplies);
err_regmap:
regmap_exit(wm8994->regmap);
mfd_remove_devices(wm8994->dev);
kfree(wm8994);
return ret;
}

Expand All @@ -576,9 +573,7 @@ static void wm8994_device_exit(struct wm8994 *wm8994)
regulator_bulk_disable(wm8994->num_supplies,
wm8994->supplies);
regulator_bulk_free(wm8994->num_supplies, wm8994->supplies);
kfree(wm8994->supplies);
regmap_exit(wm8994->regmap);
kfree(wm8994);
}

static const struct of_device_id wm8994_of_match[] = {
Expand All @@ -595,7 +590,7 @@ static int wm8994_i2c_probe(struct i2c_client *i2c,
struct wm8994 *wm8994;
int ret;

wm8994 = kzalloc(sizeof(struct wm8994), GFP_KERNEL);
wm8994 = devm_kzalloc(&i2c->dev, sizeof(struct wm8994), GFP_KERNEL);
if (wm8994 == NULL)
return -ENOMEM;

Expand All @@ -609,7 +604,6 @@ static int wm8994_i2c_probe(struct i2c_client *i2c,
ret = PTR_ERR(wm8994->regmap);
dev_err(wm8994->dev, "Failed to allocate register map: %d\n",
ret);
kfree(wm8994);
return ret;
}

Expand Down

0 comments on commit 7b70267

Please sign in to comment.