Skip to content

Commit

Permalink
Bluetooth: Use strict_strtoul instead of simple_strtoul
Browse files Browse the repository at this point in the history
Use strict_strtoul as suggested by checkpatch.pl for more strict input
checking.

Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
  • Loading branch information
Tomas Winkler authored and Marcel Holtmann committed May 10, 2010
1 parent f120c6b commit 7b767ca
Showing 1 changed file with 6 additions and 12 deletions.
18 changes: 6 additions & 12 deletions net/bluetooth/hci_sysfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -281,11 +281,9 @@ static ssize_t show_idle_timeout(struct device *dev, struct device_attribute *at
static ssize_t store_idle_timeout(struct device *dev, struct device_attribute *attr, const char *buf, size_t count)
{
struct hci_dev *hdev = dev_get_drvdata(dev);
char *ptr;
__u32 val;
unsigned long val;

val = simple_strtoul(buf, &ptr, 10);
if (ptr == buf)
if (strict_strtoul(buf, 0, &val) < 0)
return -EINVAL;

if (val != 0 && (val < 500 || val > 3600000))
Expand All @@ -305,11 +303,9 @@ static ssize_t show_sniff_max_interval(struct device *dev, struct device_attribu
static ssize_t store_sniff_max_interval(struct device *dev, struct device_attribute *attr, const char *buf, size_t count)
{
struct hci_dev *hdev = dev_get_drvdata(dev);
char *ptr;
__u16 val;
unsigned long val;

val = simple_strtoul(buf, &ptr, 10);
if (ptr == buf)
if (strict_strtoul(buf, 0, &val) < 0)
return -EINVAL;

if (val < 0x0002 || val > 0xFFFE || val % 2)
Expand All @@ -332,11 +328,9 @@ static ssize_t show_sniff_min_interval(struct device *dev, struct device_attribu
static ssize_t store_sniff_min_interval(struct device *dev, struct device_attribute *attr, const char *buf, size_t count)
{
struct hci_dev *hdev = dev_get_drvdata(dev);
char *ptr;
__u16 val;
unsigned long val;

val = simple_strtoul(buf, &ptr, 10);
if (ptr == buf)
if (strict_strtoul(buf, 0, &val) < 0)
return -EINVAL;

if (val < 0x0002 || val > 0xFFFE || val % 2)
Expand Down

0 comments on commit 7b767ca

Please sign in to comment.