Skip to content

Commit

Permalink
drm/i915: give up on 8xx lid status
Browse files Browse the repository at this point in the history
These old machines more often than not lie about their lid state.  So
don't use it to detect LVDS presence, but leave the event handler to
deal with lid open/close, when we might need to reset the mode.

Fixes kernel bug #15248

Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: stable@kernel.org
Signed-off-by: Eric Anholt <eric@anholt.net>
  • Loading branch information
Jesse Barnes authored and Eric Anholt committed Feb 22, 2010
1 parent f590d27 commit 7b9c5ab
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions drivers/gpu/drm/i915/intel_lvds.c
Original file line number Diff line number Diff line change
Expand Up @@ -648,8 +648,15 @@ static const struct dmi_system_id bad_lid_status[] = {
*/
static enum drm_connector_status intel_lvds_detect(struct drm_connector *connector)
{
struct drm_device *dev = connector->dev;
enum drm_connector_status status = connector_status_connected;

/* ACPI lid methods were generally unreliable in this generation, so
* don't even bother.
*/
if (IS_I8XX(dev))
return connector_status_connected;

if (!dmi_check_system(bad_lid_status) && !acpi_lid_open())
status = connector_status_disconnected;

Expand Down

0 comments on commit 7b9c5ab

Please sign in to comment.