Skip to content

Commit

Permalink
softlockup: fix task state setting
Browse files Browse the repository at this point in the history
kthread_stop() can be called when a 'watchdog' thread is executing after
kthread_should_stop() but before set_task_state(TASK_INTERRUPTIBLE).

Signed-off-by: Dmitry Adamushko <dmitry.adamushko@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Dmitry Adamushko authored and Ingo Molnar committed Feb 29, 2008
1 parent 2232c2d commit 7be2a03
Showing 1 changed file with 7 additions and 6 deletions.
13 changes: 7 additions & 6 deletions kernel/softlockup.c
Original file line number Diff line number Diff line change
Expand Up @@ -216,26 +216,27 @@ static int watchdog(void *__bind_cpu)
/* initialize timestamp */
touch_softlockup_watchdog();

set_current_state(TASK_INTERRUPTIBLE);
/*
* Run briefly once per second to reset the softlockup timestamp.
* If this gets delayed for more than 60 seconds then the
* debug-printout triggers in softlockup_tick().
*/
while (!kthread_should_stop()) {
set_current_state(TASK_INTERRUPTIBLE);
touch_softlockup_watchdog();
schedule();

if (kthread_should_stop())
break;

if (this_cpu != check_cpu)
continue;

if (sysctl_hung_task_timeout_secs)
check_hung_uninterruptible_tasks(this_cpu);
if (this_cpu == check_cpu) {
if (sysctl_hung_task_timeout_secs)
check_hung_uninterruptible_tasks(this_cpu);
}

set_current_state(TASK_INTERRUPTIBLE);
}
__set_current_state(TASK_RUNNING);

return 0;
}
Expand Down

0 comments on commit 7be2a03

Please sign in to comment.