Skip to content

Commit

Permalink
tracing: optimize trace_printk()
Browse files Browse the repository at this point in the history
Impact: micro-optimization

trace_printk() does this unconditionally:

	trace_printk_fmt = fmt;

Where trace_printk_fmt is an entry into a global array. This is
very SMP-unfriendly.

So only write it once per bootup.

Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Peter Zijlstra <peterz@infradead.org>
LKML-Reference: <1236356510-8381-5-git-send-email-fweisbec@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Ingo Molnar committed Mar 9, 2009
1 parent 8a20d84 commit 7bffc23
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions include/linux/kernel.h
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,10 @@ do { \
do { \
static const char *trace_printk_fmt \
__attribute__((section("__trace_printk_fmt"))); \
trace_printk_fmt = fmt; \
\
if (!trace_printk_fmt) \
trace_printk_fmt = fmt; \
\
__trace_printk_check_format(fmt, ##args); \
__trace_printk(_THIS_IP_, trace_printk_fmt, ##args); \
} while (0)
Expand All @@ -467,7 +470,10 @@ __trace_printk(unsigned long ip, const char *fmt, ...)
do { \
static const char *trace_printk_fmt \
__attribute__((section("__trace_printk_fmt"))); \
trace_printk_fmt = fmt; \
\
if (!trace_printk_fmt) \
trace_printk_fmt = fmt; \
\
__ftrace_vprintk(_THIS_IP_, trace_printk_fmt, vargs); \
} while (0)

Expand Down

0 comments on commit 7bffc23

Please sign in to comment.