Skip to content

Commit

Permalink
[media] saa7134: merge saa7134_card_ir->timer and saa7134_card_ir->ti…
Browse files Browse the repository at this point in the history
…mer_end

Both timers are used for a similar purpose. Merging them allows for some
minor simplifications.

Signed-off-by: David Härdeman <david@hardeman.nu>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
David Härdeman authored and Mauro Carvalho Chehab committed Dec 29, 2010
1 parent 651c7a5 commit 7c8352d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 7 deletions.
10 changes: 4 additions & 6 deletions drivers/media/video/saa7134/saa7134-input.c
Original file line number Diff line number Diff line change
Expand Up @@ -420,11 +420,11 @@ static int __saa7134_ir_start(void *priv)
if (ir->polling) {
setup_timer(&ir->timer, saa7134_input_timer,
(unsigned long)dev);
ir->timer.expires = jiffies + HZ;
ir->timer.expires = jiffies + HZ;
add_timer(&ir->timer);
} else if (ir->raw_decode) {
/* set timer_end for code completion */
setup_timer(&ir->timer_end, ir_raw_decode_timer_end,
setup_timer(&ir->timer, ir_raw_decode_timer_end,
(unsigned long)dev);
}

Expand All @@ -443,10 +443,8 @@ static void __saa7134_ir_stop(void *priv)
if (!ir->running)
return;

if (ir->polling)
if (ir->polling || ir->raw_decode)
del_timer_sync(&ir->timer);
else if (ir->raw_decode)
del_timer_sync(&ir->timer_end);

ir->active = false;
ir->running = false;
Expand Down Expand Up @@ -923,7 +921,7 @@ static int saa7134_raw_decode_irq(struct saa7134_dev *dev)
*/
if (!ir->active) {
timeout = jiffies + jiffies_to_msecs(15);
mod_timer(&ir->timer_end, timeout);
mod_timer(&ir->timer, timeout);
ir->active = true;
}

Expand Down
1 change: 0 additions & 1 deletion drivers/media/video/saa7134/saa7134.h
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,6 @@ struct saa7134_card_ir {
bool active;

struct timer_list timer;
struct timer_list timer_end; /* timer_end for code completion */

/* IR core raw decoding */
u32 raw_decode;
Expand Down

0 comments on commit 7c8352d

Please sign in to comment.