---

yaml --- r: 87093 b: refs/heads/master c: e24e2e6 h: refs/heads/master i: 87091: 06e7eb1 v: v3
git-mirror · Mar 11, 2008 · 7c8679e · 7c8679e
1 parent e807ed1
commit 7c8679e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/[refs] b/[refs]
@@ -1,2 +1,2 @@
 ---
-refs/heads/master: 6c5db22d280302c33dafb309c25bf2841fb99c37
+refs/heads/master: e24e2e64c468c8060bb7173abecdf11d00ed5751
diff --git a/trunk/kernel/module.c b/trunk/kernel/module.c
@@ -2178,6 +2178,14 @@ sys_init_module(void __user *umod,
 		wake_up(&module_wq);
 		return ret;
 	}
+	if (ret > 0) {
+		printk(KERN_WARNING "%s: '%s'->init suspiciously returned %d, "
+				    "it should follow 0/-E convention\n"
+		       KERN_WARNING "%s: loading module anyway...\n",
+		       __func__, mod->name, ret,
+		       __func__);
+		dump_stack();
+	}
 
 	/* Now it's a first class citizen!  Wake up anyone waiting for it. */
 	mod->state = MODULE_STATE_LIVE;