Skip to content

Commit

Permalink
[PATCH] x86: remove last two pci_find offenders in the core code
Browse files Browse the repository at this point in the history
Resending as I believe the discussion about them established they were
correct.

Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: Andi Kleen <ak@suse.de>
Cc: Andi Kleen <ak@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
  • Loading branch information
Alan Cox authored and Andi Kleen committed Dec 7, 2006
1 parent 72690a2 commit 7cd8b68
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
4 changes: 3 additions & 1 deletion arch/i386/pci/irq.c
Original file line number Diff line number Diff line change
Expand Up @@ -764,7 +764,7 @@ static void __init pirq_find_router(struct irq_router *r)
DBG(KERN_DEBUG "PCI: Attempting to find IRQ router for %04x:%04x\n",
rt->rtr_vendor, rt->rtr_device);

pirq_router_dev = pci_find_slot(rt->rtr_bus, rt->rtr_devfn);
pirq_router_dev = pci_get_bus_and_slot(rt->rtr_bus, rt->rtr_devfn);
if (!pirq_router_dev) {
DBG(KERN_DEBUG "PCI: Interrupt router not found at "
"%02x:%02x\n", rt->rtr_bus, rt->rtr_devfn);
Expand All @@ -784,6 +784,8 @@ static void __init pirq_find_router(struct irq_router *r)
pirq_router_dev->vendor,
pirq_router_dev->device,
pci_name(pirq_router_dev));

/* The device remains referenced for the kernel lifetime */
}

static struct irq_info *pirq_get_info(struct pci_dev *dev)
Expand Down
2 changes: 1 addition & 1 deletion arch/x86_64/kernel/pci-calgary.c
Original file line number Diff line number Diff line change
Expand Up @@ -921,7 +921,7 @@ static int __init calgary_init(void)

error:
do {
dev = pci_find_device_reverse(PCI_VENDOR_ID_IBM,
dev = pci_get_device_reverse(PCI_VENDOR_ID_IBM,
PCI_DEVICE_ID_IBM_CALGARY,
dev);
if (!dev)
Expand Down

0 comments on commit 7cd8b68

Please sign in to comment.