Skip to content

Commit

Permalink
[PATCH] ppc64: remove hidden -fno-omit-frame-pointer for schedule.c
Browse files Browse the repository at this point in the history
While looking at code generated by gcc4.0 I noticed some functions still
had frame pointers, even after we stopped ppc64 from defining
CONFIG_FRAME_POINTER.  It turns out kernel/Makefile hardwires
-fno-omit-frame-pointer on when compiling schedule.c.

Create CONFIG_SCHED_NO_NO_OMIT_FRAME_POINTER and define it on architectures
that dont require frame pointers in sched.c code.

(akpm: blame me for the name)

Signed-off-by: Anton Blanchard <anton@samba.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Anton Blanchard authored and Linus Torvalds committed May 5, 2005
1 parent 696c2b9 commit 7d12e52
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 1 deletion.
4 changes: 4 additions & 0 deletions arch/ia64/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,10 @@ config GENERIC_IOMAP
bool
default y

config SCHED_NO_NO_OMIT_FRAME_POINTER
bool
default y

choice
prompt "System type"
default IA64_GENERIC
Expand Down
4 changes: 4 additions & 0 deletions arch/ppc/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,10 @@ config GENERIC_NVRAM
bool
default y

config SCHED_NO_NO_OMIT_FRAME_POINTER
bool
default y

source "init/Kconfig"

menu "Processor"
Expand Down
4 changes: 4 additions & 0 deletions arch/ppc64/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,10 @@ config COMPAT
bool
default y

config SCHED_NO_NO_OMIT_FRAME_POINTER
bool
default y

# We optimistically allocate largepages from the VM, so make the limit
# large enough (16MB). This badly named config option is actually
# max order + 1
Expand Down
2 changes: 1 addition & 1 deletion kernel/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ obj-$(CONFIG_SYSFS) += ksysfs.o
obj-$(CONFIG_GENERIC_HARDIRQS) += irq/
obj-$(CONFIG_SECCOMP) += seccomp.o

ifneq ($(CONFIG_IA64),y)
ifneq ($(CONFIG_SCHED_NO_NO_OMIT_FRAME_POINTER),y)
# According to Alan Modra <alan@linuxcare.com.au>, the -fno-omit-frame-pointer is
# needed for x86 only. Why this used to be enabled for all architectures is beyond
# me. I suspect most platforms don't need this, but until we know that for sure
Expand Down

0 comments on commit 7d12e52

Please sign in to comment.