Skip to content

Commit

Permalink
usb: dwc3: pci: fix failure path in dwc3_pci_probe()
Browse files Browse the repository at this point in the history
dwc3_pci_probe() would return success even if the calls to
dwc3_get_device_id() or platform_device_alloc() fail, fix that.

Signed-off-by: Paul Zimmerman <paulz@synopsys.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
  • Loading branch information
Paul Zimmerman authored and Felipe Balbi committed Mar 2, 2012
1 parent 3e87c42 commit 7d26b58
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/usb/dwc3/dwc3-pci.c
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,10 @@ static int __devinit dwc3_pci_probe(struct pci_dev *pci,
pci_set_master(pci);

devid = dwc3_get_device_id();
if (devid < 0)
if (devid < 0) {
ret = -ENOMEM;
goto err1;
}

dwc3 = platform_device_alloc("dwc3", devid);
if (!dwc3) {
Expand Down

0 comments on commit 7d26b58

Please sign in to comment.