Skip to content

Commit

Permalink
IB/ipath: Only allow complete writes to flash
Browse files Browse the repository at this point in the history
Don't allow a write to the eeprom from ipathfs unless the write is exactly
128 bytes and starts at offset 0.

Signed-off-by: Bryan O'Sullivan <bryan.osullivan@qlogic.com>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
  • Loading branch information
Bryan O'Sullivan authored and Roland Dreier committed Sep 28, 2006
1 parent f3e93c7 commit 7dae5bf
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions drivers/infiniband/hw/ipath/ipath_fs.c
Original file line number Diff line number Diff line change
Expand Up @@ -356,19 +356,16 @@ static ssize_t flash_write(struct file *file, const char __user *buf,

pos = *ppos;

if ( pos < 0) {
if (pos != 0) {
ret = -EINVAL;
goto bail;
}

if (pos >= sizeof(struct ipath_flash)) {
ret = 0;
if (count != sizeof(struct ipath_flash)) {
ret = -EINVAL;
goto bail;
}

if (count > sizeof(struct ipath_flash) - pos)
count = sizeof(struct ipath_flash) - pos;

tmp = kmalloc(count, GFP_KERNEL);
if (!tmp) {
ret = -ENOMEM;
Expand Down

0 comments on commit 7dae5bf

Please sign in to comment.