Skip to content

Commit

Permalink
IIO: GYRO: ADXRS450: Fix sign issues, properly shift results and limi…
Browse files Browse the repository at this point in the history
…t values

RATE and QUADRATURE_CORRECTION data is formatted as a twos complement number,
and therefore must be handled as type signed short.

TEMP result should be properly shifted.

Dynamic Null Correction is a 10-bit signed number.

Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Michael Hennerich authored and Greg Kroah-Hartman committed May 3, 2011
1 parent 8ffc4e7 commit 7dd04eb
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions drivers/staging/iio/gyro/adxrs450_core.c
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ static int adxrs450_spi_write_reg_16(struct device *dev,
* @dev: device associated with child of actual iio_dev
* @val: somewhere to pass back the value read
**/
static int adxrs450_spi_sensor_data(struct device *dev, u16 *val)
static int adxrs450_spi_sensor_data(struct device *dev, s16 *val)
{
struct spi_message msg;
struct iio_dev *indio_dev = dev_get_drvdata(dev);
Expand Down Expand Up @@ -217,15 +217,15 @@ static ssize_t adxrs450_read_temp(struct device *dev,
&t);
if (ret)
return ret;
return sprintf(buf, "%d\n", t);
return sprintf(buf, "%d\n", t >> 7);
}

static ssize_t adxrs450_read_quad(struct device *dev,
struct device_attribute *attr,
char *buf)
{
int ret;
u16 t;
s16 t;
ret = adxrs450_spi_read_reg_16(dev,
ADXRS450_QUAD1,
&t);
Expand All @@ -247,7 +247,7 @@ static ssize_t adxrs450_write_dnc(struct device *dev,
goto error_ret;
ret = adxrs450_spi_write_reg_16(dev,
ADXRS450_DNC1,
val);
val & 0x3FF);
error_ret:
return ret ? ret : len;
}
Expand All @@ -257,7 +257,7 @@ static ssize_t adxrs450_read_sensor_data(struct device *dev,
char *buf)
{
int ret;
u16 t;
s16 t;

ret = adxrs450_spi_sensor_data(dev, &t);
if (ret)
Expand Down

0 comments on commit 7dd04eb

Please sign in to comment.