Skip to content

Commit

Permalink
ALSA: au88x0: Give comment for vortex_wtdma_bufshift() issue
Browse files Browse the repository at this point in the history
The check of the return value from vortex_wtdma_bufshft() in
vortex_interrupt() is useless as it executes no code.  Actually the
return value is intentionally ignored because the delta calculation
for wavetable doesn't work always correctly.  For avoiding the
confusion, a comment is added and the superfluous if () is removed.

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
  • Loading branch information
Takashi Iwai committed Oct 25, 2012
1 parent f598158 commit 7dd7a2f
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion sound/pci/au88x0/au88x0_core.c
Original file line number Diff line number Diff line change
Expand Up @@ -2461,7 +2461,12 @@ static irqreturn_t vortex_interrupt(int irq, void *dev_id)
#ifndef CHIP_AU8810
for (i = 0; i < NR_WT; i++) {
if (vortex->dma_wt[i].fifo_status == FIFO_START) {
if (vortex_wtdma_bufshift(vortex, i)) ;
/* FIXME: we ignore the return value from
* vortex_wtdma_bufshift() below as the delta
* calculation seems not working for wavetable
* by some reason
*/
vortex_wtdma_bufshift(vortex, i);
spin_unlock(&vortex->lock);
snd_pcm_period_elapsed(vortex->dma_wt[i].
substream);
Expand Down

0 comments on commit 7dd7a2f

Please sign in to comment.