Skip to content

Commit

Permalink
GFS2: Remove test which is always true
Browse files Browse the repository at this point in the history
Since gfs2_inplace_reserve() is always called with a valid
alloc parms structure, there is no need to test for this
within the function itself - and in any case, after we've
all ready dereferenced it anyway.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
  • Loading branch information
Steven Whitehouse committed Jan 3, 2014
1 parent 7aed98f commit 7de41d3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fs/gfs2/rgrp.c
Original file line number Diff line number Diff line change
Expand Up @@ -1943,7 +1943,7 @@ int gfs2_inplace_reserve(struct gfs2_inode *ip, const struct gfs2_alloc_parms *a
/* Skip unuseable resource groups */
if ((rs->rs_rbm.rgd->rd_flags & (GFS2_RGF_NOALLOC |
GFS2_RDF_ERROR)) ||
(ap && (ap->target > rs->rs_rbm.rgd->rd_extfail_pt)))
(ap->target > rs->rs_rbm.rgd->rd_extfail_pt))
goto skip_rgrp;

if (sdp->sd_args.ar_rgrplvb)
Expand Down

0 comments on commit 7de41d3

Please sign in to comment.