Skip to content

Commit

Permalink
mtd: Make SM_FTL depend on MTD_NAND
Browse files Browse the repository at this point in the history
Randy Dunlap observed a build problem with the following config:

CONFIG_SM_FTL=y
CONFIG_SM_FTL_MUSEUM=y

CONFIG_MTD_NAND=m

The ECC calculation routines are then built as a module, but referenced
by the sm_ftl code in the kernel, resulting in a build failure. The
simple fix is to make CONFIG_SM_FTL depend on MTD_NAND unconditionally
-- it's pointless without hardware support anyway.

Fix some typos which Randy pointed out, too.

Reported-By: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
  • Loading branch information
David Woodhouse authored and David Woodhouse committed Mar 9, 2010
1 parent 1f6ca0d commit 7de6f79
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions drivers/mtd/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -307,22 +307,22 @@ config SSFDC

config SM_FTL
tristate "SmartMedia/xD new translation layer"
depends on EXPERIMENTAL && BLOCK
depends on EXPERIMENTAL && BLOCK && MTD_NAND
select MTD_BLKDEVS
help
This enables new and very EXPERMENTAL support for SmartMedia/xD
FTL (Flash tanslation layer)
FTL (Flash translation layer).
Write support isn't yet well tested, therefore this code IS likely to
eat your card, so please don't use it together with valuable data.
Use readonly driver (CONFIG_SSFDC) instead.

config SM_FTL_MUSEUM
boolean "Additional Support for 1MiB and 2MiB SmartMedia cards"
depends on SM_FTL && MTD_NAND
depends on SM_FTL
select MTD_NAND_ECC_SMC
help
Very old SmartMedia cards need ECC to be calculated in the FTL
Such cards are very rare, thus enabling this option is mostly useless
Very old SmartMedia cards need ECC to be calculated in the FTL.
Such cards are very rare, thus enabling this option is mostly useless.
Also this support is completely UNTESTED.

config MTD_OOPS
Expand Down

0 comments on commit 7de6f79

Please sign in to comment.