Skip to content

Commit

Permalink
perf: Fix read buffer overflow
Browse files Browse the repository at this point in the history
Check whether index is within bounds before testing the element.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Cc: a.p.zijlstra@chello.nl
Cc: Andrew Morton <akpm@linux-foundation.org>
LKML-Reference: <4A757BCF.40101@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Roel Kluin authored and Ingo Molnar committed Aug 4, 2009
1 parent 59b9005 commit 7e03065
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion tools/perf/builtin-report.c
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ static int strcommon(const char *pathname)
{
int n = 0;

while (pathname[n] == cwd[n] && n < cwdlen)
while (n < cwdlen && pathname[n] == cwd[n])
++n;

return n;
Expand Down
2 changes: 1 addition & 1 deletion tools/perf/util/quote.c
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,7 @@ char *quote_path_relative(const char *in, int len,
strbuf_addch(out, '"');
if (prefix) {
int off = 0;
while (prefix[off] && off < len && prefix[off] == in[off])
while (off < len && prefix[off] && prefix[off] == in[off])
if (prefix[off] == '/') {
prefix += off + 1;
in += off + 1;
Expand Down

0 comments on commit 7e03065

Please sign in to comment.