Skip to content

Commit

Permalink
netxen: fix caching window register
Browse files Browse the repository at this point in the history
CRB window register is not per pci-func for NX3031,
so caching can result in incorrect values.

Signed-off-by: Amit Kumar Salecha <amit.salecha@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Amit Kumar Salecha authored and David S. Miller committed Jun 16, 2010
1 parent 2227bae commit 7e43cd6
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions drivers/net/netxen/netxen_nic_hw.c
Original file line number Diff line number Diff line change
Expand Up @@ -1159,17 +1159,13 @@ netxen_nic_pci_set_crbwindow_2M(struct netxen_adapter *adapter, ulong off)

window = CRB_HI(off);

if (adapter->ahw.crb_win == window)
return;

writel(window, addr);
if (readl(addr) != window) {
if (printk_ratelimit())
dev_warn(&adapter->pdev->dev,
"failed to set CRB window to %d off 0x%lx\n",
window, off);
}
adapter->ahw.crb_win = window;
}

static void __iomem *
Expand Down

0 comments on commit 7e43cd6

Please sign in to comment.