Skip to content

Commit

Permalink
ocfs2: Pass raw u64 to filldir
Browse files Browse the repository at this point in the history
filldir_t can take this, so don't turn de->inode into a 32 bit value. Right
now this doesn't make a difference since no ocfs2 inodes overflow that, but
it could be a nasty surprise later on if some kernel code is calling
ocfs2_dir_foreach_blk() and expecting real inode numbers back...

Signed-off-by: Mark Fasheh <mark.fasheh@oracle.com>
Reviewed-by: Joel Becker <joel.becker@oracle.com>
  • Loading branch information
Mark Fasheh committed Oct 12, 2007
1 parent b8bc5f4 commit 7e85367
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fs/ocfs2/dir.c
Original file line number Diff line number Diff line change
Expand Up @@ -512,7 +512,7 @@ static int ocfs2_dir_foreach_blk(struct inode *inode, unsigned long *f_version,
error = filldir(priv, de->name,
de->name_len,
*f_pos,
ino_from_blkno(sb, le64_to_cpu(de->inode)),
le64_to_cpu(de->inode),
d_type);
if (error)
break;
Expand Down

0 comments on commit 7e85367

Please sign in to comment.