Skip to content

Commit

Permalink
regulator: tps65910: add error message in case of failure
Browse files Browse the repository at this point in the history
Prints error message whenever there is failure on resource
allocation.
Also used dev_* to print messages instead of pr_*

Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
  • Loading branch information
Laxman Dewangan authored and Mark Brown committed May 20, 2012
1 parent 9fc3815 commit 7e9a57e
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions drivers/regulator/tps65910-regulator.c
Original file line number Diff line number Diff line change
Expand Up @@ -1101,7 +1101,7 @@ static struct tps65910_board *tps65910_parse_dt_reg_data(
matches = tps65911_matches;
break;
default:
pr_err("Invalid tps chip version\n");
dev_err(&pdev->dev, "Invalid tps chip version\n");
return NULL;
}

Expand Down Expand Up @@ -1150,12 +1150,16 @@ static __devinit int tps65910_probe(struct platform_device *pdev)
if (!pmic_plat_data && tps65910->dev->of_node)
pmic_plat_data = tps65910_parse_dt_reg_data(pdev);

if (!pmic_plat_data)
if (!pmic_plat_data) {
dev_err(&pdev->dev, "Platform data not found\n");
return -EINVAL;
}

pmic = devm_kzalloc(&pdev->dev, sizeof(*pmic), GFP_KERNEL);
if (!pmic)
if (!pmic) {
dev_err(&pdev->dev, "Memory allocation failed for pmic\n");
return -ENOMEM;
}

mutex_init(&pmic->mutex);
pmic->mfd = tps65910;
Expand All @@ -1179,7 +1183,7 @@ static __devinit int tps65910_probe(struct platform_device *pdev)
info = tps65911_regs;
break;
default:
pr_err("Invalid tps chip version\n");
dev_err(&pdev->dev, "Invalid tps chip version\n");
return -ENODEV;
}

Expand Down

0 comments on commit 7e9a57e

Please sign in to comment.