Skip to content

Commit

Permalink
cgroup: use read lock to guard find_existing_css_set()
Browse files Browse the repository at this point in the history
The function does not modify anything (except the temporary css template), so
it's sufficient to hold read lock.

Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
Acked-by: Paul Menage <menage@google.com>
Cc: Balbir Singh <balbir@linux.vnet.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Li Zefan authored and Linus Torvalds committed Jul 25, 2008
1 parent 9d96d82 commit 7e9abd8
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions kernel/cgroup.c
Original file line number Diff line number Diff line change
Expand Up @@ -415,11 +415,11 @@ static struct css_set *find_css_set(

/* First see if we already have a cgroup group that matches
* the desired set */
write_lock(&css_set_lock);
read_lock(&css_set_lock);
res = find_existing_css_set(oldcg, cgrp, template);
if (res)
get_css_set(res);
write_unlock(&css_set_lock);
read_unlock(&css_set_lock);

if (res)
return res;
Expand Down

0 comments on commit 7e9abd8

Please sign in to comment.