Skip to content

Commit

Permalink
tipc: Eliminate redundant masking in message header routines
Browse files Browse the repository at this point in the history
Gets rid of unnecessary masking in two routines that set TIPC message
header fields. (The msg_set_bits() routine already takes care of
masking the new value to the correct size.)

Signed-off-by: Allan Stephens <allan.stephens@windriver.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
  • Loading branch information
Allan Stephens authored and Paul Gortmaker committed Jun 24, 2011
1 parent 74d33b3 commit 7eb878e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions net/tipc/msg.h
Original file line number Diff line number Diff line change
Expand Up @@ -615,7 +615,7 @@ static inline u32 msg_link_selector(struct tipc_msg *m)

static inline void msg_set_link_selector(struct tipc_msg *m, u32 n)
{
msg_set_bits(m, 4, 0, 1, (n & 1));
msg_set_bits(m, 4, 0, 1, n);
}

/*
Expand All @@ -639,7 +639,7 @@ static inline u32 msg_probe(struct tipc_msg *m)

static inline void msg_set_probe(struct tipc_msg *m, u32 val)
{
msg_set_bits(m, 5, 0, 1, (val & 1));
msg_set_bits(m, 5, 0, 1, val);
}

static inline char msg_net_plane(struct tipc_msg *m)
Expand Down

0 comments on commit 7eb878e

Please sign in to comment.