Skip to content

Commit

Permalink
staging: spectra: Use memdup_user
Browse files Browse the repository at this point in the history
 Use kmemdup_user rather than duplicating its implementation
 This is a little bit restricted to reduce false positives

 The semantic patch that makes this output is available
 in scripts/coccinelle/api/memdup_user.cocci.

 More information about semantic patching is available at
 http://coccinelle.lip6.fr/

Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Thomas Meyer authored and Greg Kroah-Hartman committed Aug 23, 2011
1 parent 71c9c20 commit 7ec24db
Showing 1 changed file with 4 additions and 11 deletions.
15 changes: 4 additions & 11 deletions drivers/staging/spectra/ffsport.c
Original file line number Diff line number Diff line change
Expand Up @@ -227,19 +227,12 @@ static int ioctl_write_page_data(unsigned long arg)
if (copy_from_user(&info, (void __user *)arg, sizeof(info)))
return -EFAULT;

buf = kmalloc(IdentifyDeviceData.PageDataSize, GFP_ATOMIC);
if (!buf) {
printk(KERN_ERR "ioctl_write_page_data: "
"failed to allocate memory\n");
return -ENOMEM;
}

if (copy_from_user(buf, (void __user *)info.data,
IdentifyDeviceData.PageDataSize)) {
buf = memdup_user((void __user *)info.data,
IdentifyDeviceData.PageDataSize);
if (IS_ERR(buf)) {
printk(KERN_ERR "ioctl_write_page_data: "
"failed to copy user data\n");
kfree(buf);
return -EFAULT;
return PTR_ERR(buf);
}

mutex_lock(&spectra_lock);
Expand Down

0 comments on commit 7ec24db

Please sign in to comment.